Skip to content

Add "build project" step and misc. improvements #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2018
Merged

Conversation

nnutter
Copy link
Contributor

@nnutter nnutter commented Apr 22, 2018

For me, after sbt downloads ScalaTest the CubeCalculatorTest class
will still have several errors because ScalaTest has not been
compiled/indexed by IntelliJ IDEA so this explicitly adds a
"build project" step to trigger that.

Before I did that I wanted to fix a few other issues I noticed as I reviewed
the Markdown.

nnutter added 6 commits April 21, 2018 20:26
This indents the code blocks associated with a given list item so that
they are continuations of the list items.
This converts this list item to a ordered item so that the ordered list
is not broken by the unordered list item.
This groups the list items related to adding the ScalaTest dependency to
improve readability.
Rather than personifying the document or referring to the author(s) just
state that the tutorial assumes prior knowledge.
This rewraps a few lines to improve readability.
For me, after `sbt` downloads ScalaTest the `CubeCalculatorTest` class
will still have several errors because ScalaTest has not been
compiled/indexed by IntelliJ IDEA so this explicitly adds a
"build project" step to trigger that.
@jvican
Copy link
Member

jvican commented Apr 22, 2018

Hmm, there’s something weird. Building the project should not have anything to do with IntelliJ indexing. For example, I never build with IntelliJ and still get indexing, autocompleions and all the juicy language experience.

When I followed this tutorial I either did it really fast or in the
wrong order and ended up with `FunSuite` and `test()` not being
recognized.  I mistakenly thought building the project fixed it but it
turns out I just didn't notice that `sbt` hadn't finished syncing.
@nnutter
Copy link
Contributor Author

nnutter commented Apr 25, 2018

@jvican You're suspicion was correct. I jumped to a conclusion. It turns out it was just that the sbt sync hadn't finished. How do you feel about my correction? Worth keeping it and the other changes?

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your changes now, great work @nnutter ! 👍

@jvican jvican merged commit 9d076b0 into scala:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants